Skip to content

Remove stubs entirely#8983

Open
abadams wants to merge 5 commits intomainfrom
abadams/remove_stubs
Open

Remove stubs entirely#8983
abadams wants to merge 5 commits intomainfrom
abadams/remove_stubs

Conversation

@abadams
Copy link
Member

@abadams abadams commented Mar 4, 2026 •
edited by alexreinking
Loading

stubs never really moved beyond proof-of-concept. E.g. there is no cmake support for them, and the one app that uses them has no build.

This PR removes them entirely. Opened for discussion.

Closes #8735

@abadams @claude
Remove stubs entirely
970328f 
stubs never really moved beyond proof-of-concept. E.g. there is no cmake
support for them, and the one app that uses them has no build.

This PR removes them entirely. Opened for discussion.

Co-authored-by: Claude Code <noreply@anthropic.com>
@alexreinking alexreinking self-requested a review March 4, 2026 23:36
alexreinking
alexreinking reviewed Mar 4, 2026
View reviewed changes
Copy link
Member

@alexreinking alexreinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle, I agree with this change. It removes a source of extreme complexity with no users. Almost 2000 lines removed is a remarkable metric. We should probably send a notice to the mailing list, in case anyone there is reading and cares to weigh in.

@alexreinking alexreinking added the release_notes For changes that may warrant a note in README for official releases. label Mar 6, 2026
@alexreinking alexreinking added the dev_meeting Topic to be discussed at the next dev meeting label Mar 10, 2026
@alexreinking alexreinking mentioned this pull request Mar 13, 2026
Open
@alexreinking
Copy link
Member

alexreinking commented Mar 13, 2026 •
edited
Loading

This PR should also drop the linear_blur app, which was a stubs demo. Oh, it does! I added closes magic for #8735

@alexreinking
Copy link
Member

alexreinking commented Mar 16, 2026

This PR should probably drop the Python equivalent (Pystubs), too.

@abadams
Copy link
Member Author

abadams commented Mar 16, 2026

@vksnk is this going to break anything inside Google? Not sure if there are internal uses of stubs.

@alexreinking alexreinking requested a review from vksnk March 22, 2026 14:19
@abadams
Copy link
Member Author

abadams commented Mar 25, 2026

@vksnk gentle ping

@vksnk
Copy link
Member

vksnk commented Mar 25, 2026

Sorry for the delay, testing now.

@vksnk
Copy link
Member

vksnk commented Mar 25, 2026

Well, there is at least one project which seems to use it pretty heavily. It doesn't look like a dead code to me, but I can try to find someone to confirm/get more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexreinking alexreinking alexreinking left review comments

@vksnk vksnk Awaiting requested review from vksnk

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

dev_meeting Topic to be discussed at the next dev meeting release_notes For changes that may warrant a note in README for official releases.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add testing for linear_blur

3 participants

@abadams @alexreinking @vksnk